[css-anchor-position-1] position-area normal alignment towards non-auto inset #55722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to inset * Adds test for position-area normal alignment towards non-auto inset when only one inset is auto. * Updates some existing tests that have a single auto inset but don't expect it to have an effect. See w3c/csswg-drafts#12512
fantasai
force-pushed
the
position-area-alignment-inset
branch
from
63863c1 to
22ba030
Compare
fantasai
added a commit
to fantasai/WebKit
that referenced
this pull request
Oct 28, 2025
…opposite side https://bugs.webkit.org/show_bug.cgi?id=301406 rdar://163317238 Reviewed by NOBODY (OOPS!). Updates PositionedLayoutConstraints::resolvePosition() to unsafe-align to the non-auto inset when only one inset is auto. See: https://www.w3.org/TR/css-anchor-position/#position-area w3c/csswg-drafts#12512 Tests: imported/w3c/web-platform-tests/css/css-anchor-position/position-area-alignment-inset-001-ref.html imported/w3c/web-platform-tests/css/css-anchor-position/position-area-alignment-inset-001.html * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-alignment-inset-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-alignment-inset-001-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-alignment-inset-001.html: Added. Add new tests. See web-platform-tests/wpt#55722 * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-valid.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-after-scroll-in-document.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-after-scroll-in.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-chained-004.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-change-anchor.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-change-css-visibility.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-in-overflow-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-in-overflow-ref.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-in-overflow.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-with-position.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-remove-anchors-visible.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-remove-no-overflow.html: Modify existing tests that (unnecessarily) assumed the previous behavior. See web-platform-tests/wpt#55722 * Source/WebCore/rendering/PositionedLayoutConstraints.cpp: (WebCore::PositionedLayoutConstraints::captureInsets): Don't overwrite auto insets in our capture. (WebCore::PositionedLayoutConstraints::resolvePosition const): Check for position-area etc. directly in resolvePosition() instead. (WebCore::PositionedLayoutConstraints::insetFitsContent const): * Source/WebCore/rendering/PositionedLayoutConstraints.h: * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::computeOutOfFlowPositionedLogicalWidthUsing const): (WebCore::RenderBox::computeOutOfFlowPositionedLogicalHeightUsing const): Update sizing code to not rely on insetBefore/After().isAuto(). * Source/WebCore/rendering/style/StyleSelfAlignmentData.h: (WebCore::StyleSelfAlignmentData::isNormal const): Add convenience method.
webkit-commit-queue
pushed a commit
to fantasai/WebKit
that referenced
this pull request
Oct 29, 2025
…opposite side https://bugs.webkit.org/show_bug.cgi?id=301406 rdar://163317238 Reviewed by Alan Baradlay. Updates PositionedLayoutConstraints::resolvePosition() to unsafe-align to the non-auto inset when only one inset is auto. See: https://www.w3.org/TR/css-anchor-position/#position-area w3c/csswg-drafts#12512 Tests: imported/w3c/web-platform-tests/css/css-anchor-position/position-area-alignment-inset-001-ref.html imported/w3c/web-platform-tests/css/css-anchor-position/position-area-alignment-inset-001.html * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-alignment-inset-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-alignment-inset-001-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-alignment-inset-001.html: Added. Add new tests. See web-platform-tests/wpt#55722 * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-valid.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-after-scroll-in-document.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-after-scroll-in.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-chained-004.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-change-anchor.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-change-css-visibility.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-in-overflow-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-in-overflow-ref.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-in-overflow.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-anchors-visible-with-position.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-remove-anchors-visible.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-visibility-remove-no-overflow.html: Modify existing tests that (unnecessarily) assumed the previous behavior. See web-platform-tests/wpt#55722 * Source/WebCore/rendering/PositionedLayoutConstraints.cpp: (WebCore::PositionedLayoutConstraints::captureInsets): Don't overwrite auto insets in our capture. (WebCore::PositionedLayoutConstraints::resolvePosition const): Check for position-area etc. directly in resolvePosition() instead. (WebCore::PositionedLayoutConstraints::insetFitsContent const): * Source/WebCore/rendering/PositionedLayoutConstraints.h: * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::computeOutOfFlowPositionedLogicalWidthUsing const): (WebCore::RenderBox::computeOutOfFlowPositionedLogicalHeightUsing const): Update sizing code to not rely on insetBefore/After().isAuto(). * Source/WebCore/rendering/style/StyleSelfAlignmentData.h: (WebCore::StyleSelfAlignmentData::isNormal const): Add convenience method. Canonical link: https://commits.webkit.org/302299@main
|
There are no new test failures in Chrome or Firefox, but there are differences in the failed reftest screenshots: No Safari results, I'll close and reopen to see if that's enough to trigger them. |
|
I looked at the Chrome failures and I have no idea why it's rendering the way it is on the failing tests. The modified tests pass in Safari. |
nt1m
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See w3c/csswg-drafts#12512